Skip to content
Snippets Groups Projects

Dogfooding PolygonClassStatistics application

Merged Manuel Grizonnet requested to merge dogfooding_PolygonClassStatistics into develop
1 unresolved thread

Summary

I've used today the PolygonClassStatistics and have made few improvements to the application this morning.

These improvements concern:

  • Test output parameter filename extension before polygon analysis
  • Improvement in parameter descriptions

I hope that it could help the application usability.

Rationale

  • Indicate in the mask short description that it is a valisity mask
  • Check file extension in DoUpdateParameters
  • fix spelling

The only improvements in the application is a check of output filename extension (.XML) before performing polygons analysis. For now with a wrong extension, the exception were triggered after the analysis (which can take several minutes)

Implementation Details

Classes and files

PolygonClassStatistics is modified.

Also added a const string instead of string in OTb XML file writer.

Applications

Tests

Documentation

Improvements of PolygonClassStatistics parameters

Additional notes

Edited by Manuel Grizonnet

Merge request reports

Merged by Manuel GrizonnetManuel Grizonnet 7 years ago (Feb 20, 2018 2:17pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
34 34 #pragma GCC diagnostic ignored "-Wcast-align"
35 35 #pragma GCC diagnostic ignored "-Wunknown-pragmas"
36 36 #endif
37 #include <shark/Models/Classifier.h>
  • You have my +1 but you seem to have accidentaly included patch related to another topic here (shark version update).

  • Manuel Grizonnet added 17 commits

    added 17 commits

    • f8c813b0...8cf8a3bb - 12 commits from branch develop
    • 782ae6cb - DOC: use analyze instead of analyse (more coherent with itk/otb code)
    • 57ad476c - DOC: Indicate that PoilygonClassStatistics out parameter is an xml file in short description
    • c961654c - ENH: use const string to store filename extension
    • 025e59c3 - ENH: check output filename extension before polygon analysis to avoid useless computation
    • 16300a8d - DOC: clarify in polygon class statistics that the mask corresponds to a validy mask

    Compare with previous version

  • Thanks Julien and Remi,

    I've removed patches related to the shark topic (my mistake).

    I've got 2 '+1' I can merge this one.

  • mentioned in commit e7da5674

  • Please register or sign in to reply
    Loading