Qt4to5
We update dependencies from Qt4 to Qt5. There should be no major change in the API but here are the main modifications we made :
- Module name is now OTBQT
- Variables and macros (if home made) do not have any version number anymore
- Variables such as QT_LMAKE_EXECUTABLE or QT_LMAKE_EXECUTABLE are not cached anymore
Merge request reports
Activity
changed milestone to %6.6.0
added To Do refactoring labels
added 2 commits
- 37f33909 - COMP: #1502 (closed) Fixed warning: format ‘%s’ expects argument of type ‘char*’, but…
- 8dcff543 - COMP: #1502 (closed) Replaced some dynamic assert() by static_assert().
22 22 #ifndef __itkQtProgressBar_h 23 23 #define __itkQtProgressBar_h 24 24 25 #include <QtGui> 25 #include <QtWidgets> 26 26 #ifndef Q_MOC_RUN // See: https://bugreports.qt-project.org/browse/QTBUG-22829 //tag=QT4-boost-compatibility Problem seems to still exist with Qt5 [1]. However, the #ifndef Q_MOC_RUN directive should enclose only boost #include<> onesand not all OTB Qt classes ones.
[1] https://forum.qt.io/topic/22458/semi-solved-qt5-moc-error-in-combination-with-boost/6
I'm not able to configure the branch with the default cmake settings. I've got the following CMake error:
======================= End of OTB cmake summary ======================= CMake Error at i18n/CMakeLists.txt:70 (qt5_add_translation): Unknown CMake command "qt5_add_translation".
The reason is that there are 2 cmake option OTB_USE_QT4 and OTB_USE_QT5.
Are we agree that we need only OTB_USE_QT option which will use Qt5?
added 1 commit
- ed922b14 - SuperBuild: adding an external cmake for QT5
Yes, we are replacing qt4 by qt5 step by step. The branch cannot build with qt4. Maybe the default settings are still using QT4!
Anyway, yes we can change the name to QT instead of QTVersionNum. But we are not there yet!
This can be done when everything will be clean!Edited by Antoine Regimbeauadded 1 commit
- 211c9613 - SuperBuild: get rid of no know command line arguments
added 1 commit
- e59409e9 - SuperBuild: patch for jpeg detection on windows