See 1808

See issue 1808

This was done with this script:

    #!/bin/bash

    set -eou pipefail

    # Use C++11 sstream constructor from string
    # Exclude 'ThirdParty' because it uses ossimFilename type
    find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/std::ifstream (.*)\((.*)\.c_str\(\)/std::ifstream \1\(\2/"
    find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/std::ofstream (.*)\((.*)\.c_str\(\)/std::ofstream \1\(\2/"

    # Use C++11 ::open(const std::string&) of ifstream, ofstream, etc.
    # Exclude ThirdParty because of ossimFilename type
    find Modules/ Examples/ -not -iwholename "*ThirdParty*" -type f -print0 | xargs -0 sed -i -E "s/\.open\((.*).c_str\(\)/\.open\(\1/"

    # No need for c_str when outputing to std::cout and such
    find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/\.c_str\(\) ?<</ <</"

    # Use itk::ExceptionObject::SetDescription and SetLocation string versions
    find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/e\.SetDescription\((.*)\.c_str\(\)\)/e\.SetDescription\(\1\)/"
    find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/e\.SetLocation\((.*)\.c_str\(\)\)/e\.SetLocation\(\1\)/"

    # Use itksys::SystemTool:: string versions
    find Modules/ Examples/ -type f -print0 | xargs -0 sed -i -E "s/itksys::SystemTools::(.*)\((.*)\.c_str\(\)/itksys::SystemTools::\1\(\2/"
    # Exclude otbLogger because it uses GetCurrentDateTime which does not have a string version
    git checkout --  Modules/Core/Common/src/otbLogger.cxx
    # Exclude test/otbOGRLayerStreamStitchingFilter.cxx because there's a double use which is not compatible with the regex
    git checkout -- Modules/Segmentation/OGRProcessing/test/otbOGRLayerStreamStitchingFilter.cxx

Add a rule to check if parameter key  and description are valid for QGIS
too. ApplicationEngine must enforce this rule and TestApplication must
include an additional test case. This can be done as part of refactoring
efforts in ApplicationEngine

STY: Change ITK_OVERRIDE for override in whole code (find Modules -type f -exec sed -i 's/ITK_OVERRIDE/override/g' {} +)

BUG : Mantis-1335 : Increase monteverdi stack size and correct Segfault when rsr parameter is not provided.

Monteverdi stack size is increase in order to use 6s code.
WavelengthSpectralBandVectorType wasn't initialized and result wasn't used.

        clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.

        build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.

        #Run clang modernize check using utility script which allow to process the code in parallel (only on Applications directory)
        python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/Modules/Applications/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/Applications/*/app/*.cxx  > ~/temporary/run-clang-tidy-app-log.txt

        #Replace override by ITK macro (to maintain compat with c++98) in Modules/Applications
        find . -type f -print -name "*.cxx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'

This is a big one without much harm. It fixes incorrect spelling
and grammer when packaging OTB 5.0.0 and 5.2.0 for Debian.
Most of these changes are done by developers at DebianGIS.
For more info, I include the original patch header below.
Description: Fix some spelling errors to silence lintian
enabling  to concentrate on the real problem.
Author: Andreas Tille <tille@debian.org>
Author: Rashad Kanavath <rashad.kanavath@c-s.fr>
Author: Bas Couwenberg <sebastic@xs4all.nl>
Last-Update: 2015-12-22