Handle extended filename for DataSource class

Summary

This branch enable extension filename for OGRDataSource

Rationale

This feature comes from the issue #1520 (closed)

Implementation Details

On the same base as the ExtendedFilenameTo(Writer/Reader)Options we created a new class OGRExtendedFilenameToOptions that handle extended filename for OGRDataSource

Classes and files

A new class has been created :

A       Modules/Adapters/GdalAdapters/include/otbOGRExtendedFilenameToOptions.h
A       Modules/Adapters/GdalAdapters/src/otbOGRExtendedFilenameToOptions.cxx
M       Modules/Adapters/GdalAdapters/src/CMakeLists.txt

It interacts closely with the OGRDataSource class :

M       Modules/Adapters/GdalAdapters/include/otbOGRDataSourceWrapper.h
M       Modules/Adapters/GdalAdapters/src/otbOGRDataSourceWrapper.cxx

A small change in the api has been done : all layer creation/copy need the papszOptions as argument as a std::vector< std::string > (empty by default).

In order to be able to use the ExtendedFilenameHelper (the base class for extended filename) it has been moved to OTBCommon module.

A       Modules/Core/Common/include/otbExtendedFilenameHelper.h
M       Modules/Core/Common/otb-module.cmake
M       Modules/Core/Common/src/CMakeLists.txt
A       Modules/Core/Common/src/otbExtendedFilenameHelper.cxx
D       Modules/IO/ExtendedFilename/include/otbExtendedFilenameHelper.h
M       Modules/IO/ExtendedFilename/otb-module.cmake
M       Modules/IO/ExtendedFilename/src/CMakeLists.txt
D       Modules/IO/ExtendedFilename/src/otbExtendedFilenameHelper.cxx

Applications

No changes in application

Tests

A test has been created in order to test the new class.

M       Modules/Adapters/GdalAdapters/test/CMakeLists.txt
A       Modules/Adapters/GdalAdapters/test/otbOGRExtendedFilenameToOptionsTest.cxx

Documentation

TODO

Additional notes

This branch need real application testing so feel free to test and give feedback!

Modules/Adapters/GdalAdapters/include/otbOGRDataSourceWrapper.h

@@ -164,7 +164,7 @@ public:
    * \note No condition is assumed on the non-nullity of \c source.
    * \see \c DataSource(GDALDataset *)
    */
-  static Pointer New(ogr::version_proxy::GDALDatasetType * sourcemode, Modes::type mode = Modes::Read , std::vector< std::string > layerOptions = std::vector< std::string >() );
+  static Pointer New(ogr::version_proxy::GDALDatasetType * sourcemode, Modes::type mode = Modes::Read , const std::vector< std::string > & layerOptions = std::vector< std::string >() );
   //@}
 
   /**\name Projection Reference property */
@@ -499,9 +499,9 @@ public:
    */
     ogr::version_proxy::GDALDatasetType & ogr();
 
-    void SetLayerCreationOptions( std::vector< std::string > options );
+    void SetLayerCreationOptions( const std::vector< std::string > & options );
     void AddLayerCreationOptions( std::vector< std::string > options );
-    std::vector< std::string > GetLayerCreationOptions();
+    const std::vector< std::string > & GetLayerCreationOptions() const ;
 
 protected:
   /** Default constructor.
@@ -517,7 +517,7 @@ protected:
   /** Init constructor.
    * \post The newly constructed object owns the \c source parameter.
    */
-  DataSource(ogr::version_proxy::GDALDatasetType * source, Modes::type mode , std::vector< std::string > layerOption = std::vector< std::string >() );
+  DataSource(ogr::version_proxy::GDALDatasetType * source, Modes::type mode , const std::vector< std::string > & layerOption = std::vector< std::string >() );
   /** Destructor.
    * \post The \c GDALDataset owned is released (if not null).
    */