Handle extended filename for DataSource class

Summary

This branch enable extension filename for OGRDataSource

Rationale

This feature comes from the issue #1520 (closed)

Implementation Details

On the same base as the ExtendedFilenameTo(Writer/Reader)Options we created a new class OGRExtendedFilenameToOptions that handle extended filename for OGRDataSource

Classes and files

A new class has been created :

A       Modules/Adapters/GdalAdapters/include/otbOGRExtendedFilenameToOptions.h
A       Modules/Adapters/GdalAdapters/src/otbOGRExtendedFilenameToOptions.cxx
M       Modules/Adapters/GdalAdapters/src/CMakeLists.txt

It interacts closely with the OGRDataSource class :

M       Modules/Adapters/GdalAdapters/include/otbOGRDataSourceWrapper.h
M       Modules/Adapters/GdalAdapters/src/otbOGRDataSourceWrapper.cxx

A small change in the api has been done : all layer creation/copy need the papszOptions as argument as a std::vector< std::string > (empty by default).

In order to be able to use the ExtendedFilenameHelper (the base class for extended filename) it has been moved to OTBCommon module.

A       Modules/Core/Common/include/otbExtendedFilenameHelper.h
M       Modules/Core/Common/otb-module.cmake
M       Modules/Core/Common/src/CMakeLists.txt
A       Modules/Core/Common/src/otbExtendedFilenameHelper.cxx
D       Modules/IO/ExtendedFilename/include/otbExtendedFilenameHelper.h
M       Modules/IO/ExtendedFilename/otb-module.cmake
M       Modules/IO/ExtendedFilename/src/CMakeLists.txt
D       Modules/IO/ExtendedFilename/src/otbExtendedFilenameHelper.cxx

Applications

No changes in application

Tests

A test has been created in order to test the new class.

M       Modules/Adapters/GdalAdapters/test/CMakeLists.txt
A       Modules/Adapters/GdalAdapters/test/otbOGRExtendedFilenameToOptionsTest.cxx

Documentation

TODO

Additional notes

This branch need real application testing so feel free to test and give feedback!

Modules/Adapters/GdalAdapters/include/otbOGRExtendedFilenameToReaderOptions.h

+/*
+ * Copyright (C) 2005-2017 Centre National d'Etudes Spatiales (CNES)
+ *
+ * This file is part of Orfeo Toolbox
+ *
+ *     https://www.orfeo-toolbox.org/
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef otbOGRExtendedFilenameToReaderOptions_h
+#define otbOGRExtendedFilenameToReaderOptions_h
+
+#include <set>
+#include "otbExtendedFilenameHelper.h"
+
+namespace otb
+{
+
+/** \class OGRExtendedFilenameToReaderOptions
+ */
+
+class ITK_EXPORT OGRExtendedFilenameToReaderOptions : public ExtendedFilenameHelper
+{
+public:
+  /** Standard class typedefs. */
+  typedef OGRExtendedFilenameToReaderOptions Self;
+  typedef itk::SmartPointer<Self> Pointer;
+  typedef itk::SmartPointer<const Self> ConstPointer;
+  typedef ExtendedFilenameHelper Superclass;
+
+  typedef Superclass::OptionMapType OptionMapType;
+  typedef OptionMapType::iterator MapIteratorType;
+
+  itkTypeMacro(OGRExtendedFilenameToReaderOptions, otb::ExtendedFilenameHelper);
+  itkNewMacro(Self);
+
+  /** The creation option structure. */
+  struct OptionType
+  {
+    std::pair< bool , std::string > simpleFileName;
+    std::pair< bool , std::string > shapeFileType;
+    std::set< std::string > availableOptions;
+  };
+
+  /* Set Methods */
+  void SetExtendedFileName(const char * extFname) override;
+
+protected:
+  OGRExtendedFilenameToReaderOptions();
+  ~OGRExtendedFilenameToReaderOptions() override {};
+
+private:
+  OGRExtendedFilenameToReaderOptions(const Self &) = delete ;
+  void operator =(const Self&) = delete ;
+
+  OptionType m_Options;
+};
+
+} //end namespace otb
+
+#endif // otbOGRExtendedFilenameToReaderOptions_h