Remove CommandLineParser submodule

Summary

CommandLineParser is now removed from OTB.

Rationale

OTB needs to loose weight!

Implementation Details

CommandLineParser was mainly used in test. I replaced it with the appropriate use of argv and argc.

Tests

Some test where not executed, for now there are commented, we can decide here to remove them in this MR or create a new MR to reinstate those test with there baselines.
I believe that those are not the only test written but not executed in OTB. Maybe we could clean other tests or reinstate them.

• otbAngularProjectionSetImageFilter.cxx
• otbAngularProjectionImageFilter.cxx
• otbAngularProjectionBinaryImageFilter.cxx
• otbSparseWvltToAngleMapperListFilter.cxx
• otbFastICAImageFilter.cxx
• otbSparseUnmixingImageFilter.cxx

I deleted one test : 0000094-PolygonsVectorization.cxx during a raging fever. Again we can decide to make it great again.

Documentation

Some example and documentation were updated also, but only one was a bit touchy : Tutorials/SmarterFilteringPipeline.cxx

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

Examples/ChangeDetection/KullbackLeiblerSupervizedDistanceChDet.cxx

@@ -26,7 +26,6 @@
 #include "otbImageFileReader.h"
 #include "otbImageFileWriter.h"
 #include "otbCommandProgressUpdate.h"
-#include "otbCommandLineArgumentParser.h"
 
 #include "otbKullbackLeiblerSupervizedDistanceImageFilter.h"
 
@@ -34,36 +33,13 @@ int main(int argc, char * argv[])
 {
   try
     {
-
-    typedef otb::CommandLineArgumentParser ParserType;
-    ParserType::Pointer parser = ParserType::New();
-    parser->AddOption("--InputImage1", "Give Before image", "-1", 1, true);
-    parser->AddOption("--InputImage2", "Give After image", "-2", 1, true);
-    parser->AddOption("--Roi", "Give ROI image", "-r", 1, true);
-    parser->AddOption("--winSize",
-                      "Sliding window size (def. 35)",
-                      "-w",
-                      1,
-                      false);
-    parser->AddOutputImage();
-
-    typedef otb::CommandLineArgumentParseResult ParserResultType;
-    ParserResultType::Pointer parseResult = ParserResultType::New();
-
-    try
-      {
-      parser->ParseCommandLine(argc, argv, parseResult);
-      }
-    catch (itk::ExceptionObject& err)
+    if( argc < 5 )
       {
-      std::string descriptionException = err.GetDescription();
-      if (descriptionException.find("ParseCommandLine(): Help Parser")
-          != std::string::npos) return EXIT_SUCCESS;
-      if (descriptionException.find("ParseCommandLine(): Version Parser")
-          != std::string::npos) return EXIT_SUCCESS;
+      std::cerr << "Usage: " << argv[0];
+      std::cerr << "inputNameImage1 inputNameImage2 ROIImageName outputName ";
+      std::cerr << "[winSize=35]";
       return EXIT_FAILURE;
       }
-
     /*
      *  Types declaration
      */
@@ -83,18 +59,14 @@ int main(int argc, char * argv[])
      * Extract command line parameters
      */
 
-    std::string inputImageFileName1 = parseResult->GetParameterString(
-      "--InputImage1");
-    std::string inputImageFileName2 = parseResult->GetParameterString(
-      "--InputImage2");
-    std::string inputTrainingImageFileName = parseResult->GetParameterString(
-      "--Roi");
-    std::string outputImageFileName = parseResult->GetOutputImage();
+    std::string inputImageFileName1 = argv[1];
+    std::string inputImageFileName2 = argv[2];
+    std::string inputTrainingImageFileName = argv[3];
+    std::string outputImageFileName = argv[4];
 
     int winSize = 35;
-    if (parseResult->IsOptionPresent("--winSize"))
-      winSize =
-        parseResult->GetParameterInt("--winSize");
+    if ( argc == 6 )
+      winSize = std::stoi(argv[5]);
 
     /*
      *  JustDoIt