COMP: Set boost configure specific options when building with clang on unix systems

Closes #1800 (closed)

can you test this with the superbuild branch system?

I was also investigating this issue on behalf on @esarrazin

I think we should also forward the compilation flags. For instance, if we wish to use an implementation of the C++ standard library that is not the one built into clang to be used by default, then this information (--stdlib=libc++/--stdlib=libstdc++) will not be propagated. Same thing with sanitization options, C++ standard flavour to use (C++14, 17, 20...)

EDIT: BTW, what about other toolsets (like for instance the Intel C++ compiler)

@poughov done

@lhermitte, I can do cxxflags=${CMAKE_CXX_FLAGS} but linkflags I do not know which cmake variable to use (EXE_LINKER, MODULE_LINKER, SHARED_LINKER ...) ? Regarding other toolkits, I would say that we should not add support for things we do not test ...

That's a good question. I must admit I don't know the exact differences between MODULE VS SHARED/STATIC flags. I suspect linkflags is generic (regarding static/dynamic), the additional flags being provided by b2 when a static or a dynamic library is produced. This is just a wild guess.

added to dashboard testing

Status: dashboard green, needs votes

hmm actually no not green. Superbuild branch has build errors on leod

yes and here is the error : bootstrap.log

This can be solved if we get rid of openMP in Superbuild. Thus we will come back to a native compiler on leod. I will propose such a MR soon.

Before removing OpenMP from the SuperBuild, can we track down the reasons it was added in the first place and make sure it doesn't apply anymore? Just to make sure we are not undoing, doing, undoing, etc...

We added OpenMP to package the DiapOTB remote module. Removing OpenMP will require to update DiapOTB code to make the use of OpenMP optional.

I can also update this patch to apply it on linux only.

added 1 commit

• 73ac55e4 - COMP: avoid doing clang specific setup for mac osx

Compare with previous version

@jmichel can we merge or removed this from the dashboard?

I think it can be merged (I added a guard to do it only on linux). Dashboard is ok.

mentioned in commit e7ba73db

merged

changed milestone to %7.0.0