Fix ImageFileReader error message & add back otb::Logger::BuildFormattedEntry
Summary
- Fix unclear error message in ImageFileReader (see discussion in #1850 (closed))
- Add back
otb::Logger::BuildFormattedEntry
override (removed in !379 (merged))
Rationale
- Fix issue #1850 (closed)
- Better format for log entries (no redundant spaces and don't show logger name)
Copyright
The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.
Check before merging:
- All discussions are resolved
- At least 2
votes from core developers, no vote. - The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Merge request reports
Activity
added bug refactoring labels
Suggested reviewers @lhermitte @aregimbeau
btw I've updated the testIOErrors.py script for this branch: https://gitlab.orfeo-toolbox.org/snippets/128
- Resolved by Victor Poughon
- Resolved by Victor Poughon
- Resolved by Victor Poughon
- Resolved by Victor Poughon
It's not the same at all :) Small differences like removing extra spaces and not showing the logger name. I introduced it 2 years ago back when I did the work on improving error message. But yes I copy pasted from the ITK one so I understand your confusion. With the code review from Luc also I just pushed a commit that simplifies it a lot (since we are always in the HUMANREADABLE mode). It should be more clear now.
added 1 commit
- d6cb4b11 - REFAC: refactor otb::Logger::BuildFormattedEntry
ok done! You can see what it looks like here: https://gitlab.orfeo-toolbox.org/snippets/128
mentioned in merge request !405 (merged)