An error occurred while fetching reviewers.
BUG: migrate to QOpenGLWidget
Summary
In Monteverdi's ImageViewWidget
, migrate QGLWidget
to QOpenGLWidget
introduced in Qt 5.4.
Rationale
The old QGLWidget is obsolete in Qt 5.
After this patch the performance of image browsing in Monteverdi on my machine is increased dramatically. I can browse an image smoothly while it was very slow before.
Please see the Qt Documentation for QOpenGLWidget for details on the differences between the two.
Closes #1626 (closed). Probably closes #1796 (closed).
Copyright
The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.
Check before merging:
- All discussions are resolved
- At least 2
votes from core developers, no vote. - The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
- Optionally, run
git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i
on latest changes and commit
Edited by Victor Poughon
Merge request reports
Activity
added feature label
added bug label
mentioned in merge request !652 (merged)
mentioned in commit e8b88b79
changed milestone to %7.1.0
Please register or sign in to reply