Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 206
    • Issues 206
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !655

BUG: migrate to QOpenGLWidget

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Victor Poughon requested to merge 1626-qopenglwidget into develop Dec 19, 2019
  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 6

Summary

In Monteverdi's ImageViewWidget, migrate QGLWidget to QOpenGLWidget introduced in Qt 5.4.

Rationale

The old QGLWidget is obsolete in Qt 5.

After this patch the performance of image browsing in Monteverdi on my machine is increased dramatically. I can browse an image smoothly while it was very slow before.

Please see the Qt Documentation for QOpenGLWidget for details on the differences between the two.

Closes #1626 (closed). Probably closes #1796 (closed).

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited Dec 19, 2019 by Victor Poughon
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1626-qopenglwidget