Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 207
    • Issues 207
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !770

Parse optical metadata from geom

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Cédric Traizet requested to merge optical_imi_geom into develop Nov 17, 2020
  • Overview 2
  • Commits 14
  • Pipelines 8
  • Changes 50

Summary

In !765 (merged) the parsing of optical metadata from raw products has been refactored to use the new metadata framework introduced in !707 (merged). To ensure backward compatibility, OTB should also be able to read metadata from geom files. Generic metadata parsing from geom has been added in !759 (merged), but metadata specific to optical products were not parsed in the ImageMetadataInterface classes.

This Merge Request adds parsing from geom in optical products.

Other changes:

  • The signature of the Parse method of ImageMetadataInterfaceBase has been changed to use const reference instead of pointer:
virtual void ImageMetadataInterfaceBase::Parse(const MetadataSupplierInterface & mds)

Tests

One test per product has been added. The metadata from a product is compared with the metadata read from a geom file using the --compare-metadata utility refactored in !763 (merged)

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited Nov 17, 2020 by Cédric Traizet
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: optical_imi_geom