Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
otb
otb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 273
    • Issues 273
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 8
    • Merge Requests 8
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Main Repositories
  • otbotb
  • Merge Requests
  • !775

Merged
Opened Nov 24, 2020 by Cédric Traizet@ctraizetDeveloper

Fix CosmoSkyMed ImageMetadataInterface

  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 1

Summary

  • Test that the product is CosmoSkyMed before trying to open the hdf5 subdatasets.
  • Remove unused code

Rationale

Currently, opening an image that is not a CosmoSkyMed product leads to the following logs:

HDF5-DIAG: Error detected in HDF5 (1.10.1) thread 0:
  #000: /home/cedric/OTB/Superbuild/HDF5/src/HDF5/src/H5F.c line 586 in H5Fopen(): unable to open file
    major: File accessibilty
    minor: Unable to open file
  #001: /home/cedric/OTB/Superbuild/HDF5/src/HDF5/src/H5Fint.c line 1384 in H5F_open(): unable to read superblock
    major: File accessibilty
    minor: Read failed
  #002: /home/cedric/OTB/Superbuild/HDF5/src/HDF5/src/H5Fsuper.c line 360 in H5F__super_read(): file signature not found
    major: File accessibilty
    minor: Not an HDF5 file

(note that this does not cause a crash)

because CosmoImageMetadataInterface::Parse tries to open hdf5 subdatasets before determining if the product is or is not a Cosmo product.

This is a regression introduced in !761 (merged)

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Assignee
Assign to
Reviewer
Request review from
8.0.0
Milestone
8.0.0
Assign milestone
Time tracking
Reference: orfeotoolbox/otb!775
Source branch: cosmo_hdf5_logs

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.