Fix CosmoSkyMed ImageMetadataInterface

Summary

• Test that the product is CosmoSkyMed before trying to open the hdf5 subdatasets.
• Remove unused code

Rationale

Currently, opening an image that is not a CosmoSkyMed product leads to the following logs:

HDF5-DIAG: Error detected in HDF5 (1.10.1) thread 0:
  #000: /home/cedric/OTB/Superbuild/HDF5/src/HDF5/src/H5F.c line 586 in H5Fopen(): unable to open file
    major: File accessibilty
    minor: Unable to open file
  #001: /home/cedric/OTB/Superbuild/HDF5/src/HDF5/src/H5Fint.c line 1384 in H5F_open(): unable to read superblock
    major: File accessibilty
    minor: Read failed
  #002: /home/cedric/OTB/Superbuild/HDF5/src/HDF5/src/H5Fsuper.c line 360 in H5F__super_read(): file signature not found
    major: File accessibilty
    minor: Not an HDF5 file

(note that this does not cause a crash)

because CosmoImageMetadataInterface::Parse tries to open hdf5 subdatasets before determining if the product is or is not a Cosmo product.

This is a regression introduced in !761 (merged)

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Modules/Core/Metadata/src/otbCosmoImageMetadataInterface.cxx

@@ -359,44 +359,28 @@ void CosmoImageMetadataInterface::Parse(const MetadataSupplierInterface & mds)
 {
   assert(mds.GetNbBands() == this->m_Imd.Bands.size());
 
-  // Check SubDatasets (For COSMO, we need //S01/SBI dataset)
-  auto subDsName = "HDF5:" + mds.GetResourceFile() + "://S01/SBI";
-  auto ds = (GDALDataset *) GDALOpen(subDsName.c_str(), GA_ReadOnly );
+  // Check Mission Id, acquisition mode and product type
+  Fetch(MDStr::Mission, mds, "MISSION_ID");
 
-  if (ds)
-  {
-    std::cout << "Found S01/SBI ! " << std::endl;
-    // Do stuff
-    GDALClose(ds);
-  }
-  else
+  if (m_Imd[MDStr::Mission] != "CSK" )
   {
     otbGenericExceptionMacro(MissingMetadataException,
-      << "Cannot find S01/SBI subdataset")
+      << "Not a CosmoSkyMed product");
   }
 
-  // Metadata read by GDAL
-
-  Fetch(MDStr::Mission, mds, "MISSION_ID");
   Fetch(MDStr::Mode, mds, "Acquisition_Mode");
-  Fetch(MDStr::ProductType, mds, "Product_Type");
-
-  // Check Mission Id, acquisition mode and product type
-  if(! (m_Imd[MDStr::Mission] == "CSK" ))
-    {
-    itkWarningMacro(<< "Not a valid missionId" << m_Imd[MDStr::Mission] );
-    }
   if((m_Imd[MDStr::Mode] != "HIMAGE") &&
         (m_Imd[MDStr::Mode] != "SPOTLIGHT") &&
           (m_Imd[MDStr::Mode] != "ENHANCED SPOTLIGHT"))
-    {
+  {
     itkWarningMacro(<< "Not an expected acquisition mode (only HIMAGE and SPOTLIGHT expected)" << m_Imd[MDStr::Mode] );
-    }
-
+  }
+  
+  Fetch(MDStr::ProductType, mds, "Product_Type");
   if( (m_Imd[MDStr::ProductType] != "SCS_B") && m_Imd[MDStr::ProductType] != "SCS_U")
-    {
+  {
     itkWarningMacro(<< "Not an expected product type (only SCS_B and SCS_U expected) " << m_Imd[MDStr::ProductType] );
-    }
+  }
 
   m_Imd.Add(MDStr::SensorID, "CSK");
   Fetch(MDStr::Instrument, mds, "Satellite_ID");
@@ -418,7 +402,8 @@ void CosmoImageMetadataInterface::Parse(const MetadataSupplierInterface & mds)
   m_Imd.Add(MDNum::PRF, std::stoi(PRFNumber));
 
 
-  //getTIme
+  //getTime
+  auto subDsName = "HDF5:" + mds.GetResourceFile() + "://S01/SBI";
   auto metadataBands = this->saveMetadataBands(subDsName) ;
   bool hasTimeUTC;
   int pos = mds.GetMetadataValue("Reference_UTC", hasTimeUTC).find(" ");;