Skip to content

Fix unreleased reference count

Luc Hermitte requested to merge lhermitte/otb:AutoLightObjects into develop

Summary

Fixes crashing tests (in non release mode), related to itk::LightObject check in its destructor.

assert(!"Trying to delete object with non-zero reference count.");

Rationale

otb::Function::AmplitudeFunctor, otb::Function::PhaseFunctor and otb::ScalarToRainbowRGBPixelFunctor all inherit from itk::LightObject. Instances of this type needs to be created through their related ::New() functions and handled through ITK smart-pointer. In the case they are directly put on the stack/handled automatically, the reference count will never reach 0, which is considered a programming error (hint: the assertion & and the following warning in release mode).

Implementation Details

The two phase and amplitude functor tests no longer create the functors on the stack but through :New().

And otb::ScalarToRainbowRGBPixelFunctor has been refactored to integrate the code from its direct ITK parent type (which is an ITK function and not a ITK functor) and remove the coupling to itk::LightObject. This permits to store it in itk::UnaryFunction<>

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Merge request reports