Fix unreleased reference count

Summary

Fixes crashing tests (in non release mode), related to itk::LightObject check in its destructor.

assert(!"Trying to delete object with non-zero reference count.");

Rationale

otb::Function::AmplitudeFunctor, otb::Function::PhaseFunctor and otb::ScalarToRainbowRGBPixelFunctor all inherit from itk::LightObject. Instances of this type needs to be created through their related ::New() functions and handled through ITK smart-pointer. In the case they are directly put on the stack/handled automatically, the reference count will never reach 0, which is considered a programming error (hint: the assertion & and the following warning in release mode).

Implementation Details

The two phase and amplitude functor tests no longer create the functors on the stack but through :New().

And otb::ScalarToRainbowRGBPixelFunctor has been refactored to integrate the code from its direct ITK parent type (which is an ITK function and not a ITK functor) and remove the coupling to itk::LightObject. This permits to store it in itk::UnaryFunction<>

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

added bug label

changed milestone to %8.2.0

added 1 commit

• decd064e - COMP: Add OTBCommon dependency to ColorMap

Compare with previous version

added 1 commit

• ab734080 - BUG: Fix unreleased ref count: color map II

Compare with previous version

added 31 commits

• ab734080...1f125c6c - 30 commits from branch orfeotoolbox:develop
• 9ff441f7 - Merge branch 'develop' into AutoLightObjects

Compare with previous version

added 3 commits

• 1e6cd0ef - BUILD: Migrate expat from sourceforge to github
• 72679b57 - BUILD: Use expat.tar.gz to keep md5sum
• a381c4bb - Merge branch 'MigrateExpatToGithub' into AutoLightObjects

Compare with previous version

approved this merge request

changed title from BUG: fix unreleased reference count to Fix unreleased reference count

added 65 commits

• a381c4bb...6cddac7c - 64 commits from branch orfeotoolbox:develop
• 5bbc1d2a - Merge branch 'develop' into 'AutoLightObjects'

Compare with previous version

mentioned in commit 03d6e392

merged

changed milestone to %9.0.0