Handle extended filename for DataSource class

Summary

This branch enable extension filename for OGRDataSource

Rationale

This feature comes from the issue #1520 (closed)

Implementation Details

On the same base as the ExtendedFilenameTo(Writer/Reader)Options we created a new class OGRExtendedFilenameToOptions that handle extended filename for OGRDataSource

Classes and files

A new class has been created :

A       Modules/Adapters/GdalAdapters/include/otbOGRExtendedFilenameToOptions.h
A       Modules/Adapters/GdalAdapters/src/otbOGRExtendedFilenameToOptions.cxx
M       Modules/Adapters/GdalAdapters/src/CMakeLists.txt

It interacts closely with the OGRDataSource class :

M       Modules/Adapters/GdalAdapters/include/otbOGRDataSourceWrapper.h
M       Modules/Adapters/GdalAdapters/src/otbOGRDataSourceWrapper.cxx

A small change in the api has been done : all layer creation/copy need the papszOptions as argument as a std::vector< std::string > (empty by default).

In order to be able to use the ExtendedFilenameHelper (the base class for extended filename) it has been moved to OTBCommon module.

A       Modules/Core/Common/include/otbExtendedFilenameHelper.h
M       Modules/Core/Common/otb-module.cmake
M       Modules/Core/Common/src/CMakeLists.txt
A       Modules/Core/Common/src/otbExtendedFilenameHelper.cxx
D       Modules/IO/ExtendedFilename/include/otbExtendedFilenameHelper.h
M       Modules/IO/ExtendedFilename/otb-module.cmake
M       Modules/IO/ExtendedFilename/src/CMakeLists.txt
D       Modules/IO/ExtendedFilename/src/otbExtendedFilenameHelper.cxx

Applications

No changes in application

Tests

A test has been created in order to test the new class.

M       Modules/Adapters/GdalAdapters/test/CMakeLists.txt
A       Modules/Adapters/GdalAdapters/test/otbOGRExtendedFilenameToOptionsTest.cxx

Documentation

TODO

Additional notes

This branch need real application testing so feel free to test and give feedback!

Modules/Adapters/GdalAdapters/include/otbOGRExtendedFilenameToOptions.h

@@ -21,7 +21,7 @@
 #ifndef otbOGRExtendedFilenameToOptions_h
 #define otbOGRExtendedFilenameToOptions_h
 
-#include <set>
+#include <unordered_map>
 #include "otbExtendedFilenameHelper.h"
 
 namespace otb
@@ -51,21 +51,20 @@ public:
   struct OpenOptionType
   {
     std::pair< bool, std::string  > simpleFileName;
-    std::pair< bool, GDALOptionType > gdalOptions;
-    std::map< std::string , bool > availableOptions;
+    GDALOptionType gdalOptions;
+    // std::unordered_map< std::string , bool > availableOptions;
   };
 
   struct CreationOptionType
   {
     std::pair< bool, std::string  > simpleFileName;
-    std::pair< bool, GDALOptionType > gdalOptions;
-    std::map< std::string , bool > availableOptions;
+    GDALOptionType gdalOptions;
+    // std::unordered_map< std::string , bool > availableOptions;
   };
 
   struct LayerOptionType
   {
-    std::pair< bool, GDALOptionType > gdalOptions;
-    std::map< std::string , bool > availableOptions;
+    std::unordered_map< std::string , std::string > gdalOptions;
   };
 
   /* Set Methods */
@@ -77,6 +76,9 @@ public:
   GDALOptionType GetGDALCreationOptions() const ;
   GDALOptionType GetGDALLayerOptions() const ;
 
+  void SetGDALLayerOptions( const GDALOptionType & options );
+  void AddGDALLayerOptions( const GDALOptionType & options );
+
 
 
 protected: